[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate
Aaron Puchert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 31 14:25:17 PDT 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362266: Clarify when fix-it hints on warnings are appropriate (authored by aaronpuchert, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
CHANGES SINCE LAST ACTION
@@ -423,6 +423,9 @@
driver, they should only be used when it's very likely they match the user's
* Clang must recover from errors as if the fix-it had been applied.
+* Fix-it hints on a warning must not change the meaning of the code.
+ However, a hint may clarify the meaning as intentional, for example by adding
+ parentheses when the precedence of operators isn't obvious.
If a fix-it can't obey these rules, put the fix-it on a note. Fix-its on notes
are not applied automatically.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 697 bytes
Desc: not available
More information about the llvm-commits