[PATCH] D62608: [ARM64, COFF] Add CodeView register mapping

[Tom Tan via Phabricator via llvm-commits]

TomTan marked 2 inline comments as done.
TomTan added inline comments.


================
Comment at: lib/DebugInfo/PDB/Native/NativeSession.cpp:86
 
-std::unique_ptr<PDBSymbolExe> NativeSession::getGlobalScope() {
+std::unique_ptr<PDBSymbolExe> NativeSession::getGlobalScope() const {
   return PDBSymbol::createAs<PDBSymbolExe>(*this, getNativeGlobalScope());
----------------
rnk wrote:
> Did you mean to add const here? It doesn't seem necessary, please revert it if so.
Thanks for the catch. Yes, this is unnecessary. I tried query `CPUType` from `getGlobalScope()`, but found a class variable `CompilationCPU` for that. I'll revert the all added `const` for `getLobalScope()`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62608/new/

https://reviews.llvm.org/D62608