[PATCH] D62403: [PowerPC] check for INLINEASM_BR along w/ INLINEASM
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 31 13:52:11 PDT 2019
nickdesaulniers added a comment.
> Also, I'm fine with these as by-inspection changes, but if there are reasonably-easy ways to write test cases (or update existing ones), please do.
Thank you for the review, and I understand. Short of writing a full on unit test (`llvm/unittests/Target/PowerPC/testcase.cpp`) I don't have a reproducer in hand nor know enough about PPC assembly to derive a test case that exposes the same issue as seen on arm. Maybe something where a large amount of inline asm in a `callbr` would prevent inlining, but even that is kind of brittle. Merging for now, but if you have more ideas I'm happy to commit tests after the fact.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits