[PATCH] D62749: [X86] remove derived method w/ same impl as base
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 31 13:52:10 PDT 2019
nickdesaulniers added a comment.
Adding @hfinkel for review because I think we can go further. The only other override of `TargetInstrInfo::isUnpredicatedTerminator` is `PPCInstrInfo::isUnpredicatedTerminator` and it almost matches, modulo a check for whether the `MachineInstr` `isPredicable`. I'm not sure if that's intentional, or bug, but adding `return TargetInstrInfo::isUnpredicatedTerminator(MI);` as the first statement in `PPCInstrInfo::isUnpredicatedTerminator` doesn't cause any failures in existing tests.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits