[PATCH] D62747: [InlineCost] Don't add the soft float functional call cost for the fneg idiom, fsub -0.0, %x

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 13:37:47 PDT 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/InlineCost.cpp:1099
   // is expensive, this may eventually become a library call. Treat the cost
-  // as such.
+  // as such. Unless its fneg which can be implemented with an xor.
+  using namespace llvm::PatternMatch;
----------------
"it's"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62747/new/

https://reviews.llvm.org/D62747





More information about the llvm-commits mailing list