[PATCH] D62443: [WebAssembly] Move Emscripten-specific behavior under a --emscripten flag

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 11:05:18 PDT 2019

sbc100 added a comment.

I have proposed https://reviews.llvm.org/D62744 which covers most of the changes here.

For `-pie/-shared` I'd rather not add a `--emscripten` flag.  In fact I'd rather not have such a flag at all.    Some background that might help here:  The PIC support in LLVM actually the experimental (although unstable) spec specified in  https://github.com/WebAssembly/tool-conventions/blob/master/DynamicLinking.md.  Note that this document includes both the "emscripten" way of doing things and the future "Planned Changes" way of doing things which is implemented in LLVM.     emscripten-wasm-finalize, which is part of binaryen, then converts from the LLVM/official ABI to the emscripten ABI for dynamic linking.   I will update the docs to be more clear but as I see it non of the PIC support in LLVM is emscripten-specific.

If you really want to add a new flag I'd be OK with "--experimental".. but I'd rather not have either.  Have you been experiencing issues with people passing `-pie/-shared` this flag and getting unexpected results?




More information about the llvm-commits mailing list