[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

Melanie Blower via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 08:19:14 PDT 2019

mibintc added inline comments.

Comment at: include/llvm/IR/IRBuilder.h:234
+  /// Set the exception handling to be used with constrained floating point
+  void setDefaultConstrainedExcept(MDNode *NewExcept) { 
+    DefaultConstrainedExcept = NewExcept; 
kpn wrote:
> mibintc wrote:
> > andrew.w.kaylor wrote:
> > > I think it would be better to add some enumerated type to describe the exception semantic and rounding modes. The MDNode is an implementation detail and an awkward one for the front end to have to deal with.
> > I posted a patch showing the rounding and exception information being passed as enumeration not MDNode. I've uploaded the patch here, https://reviews.llvm.org/D62730
> It's a good idea. D62730 beat me to the punch.
BTW I created FPState.h because if I put the enumeration types in IRBuilder it dragged in too many include files in clang and required other random source changes for disambigutation.  Anyway I don't need to comandeer your patch -- I don't want it to die from neglect.  I can close mine? 



More information about the llvm-commits mailing list