[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

Melanie Blower via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 07:24:00 PDT 2019

mibintc added a comment.

I've posted a small change to this patch here, https://reviews.llvm.org/D62730 and there's a patch to add clang fp options here, https://reviews.llvm.org/D62731

Comment at: include/llvm/IR/IRBuilder.h:234
+  /// Set the exception handling to be used with constrained floating point
+  void setDefaultConstrainedExcept(MDNode *NewExcept) { 
+    DefaultConstrainedExcept = NewExcept; 
andrew.w.kaylor wrote:
> I think it would be better to add some enumerated type to describe the exception semantic and rounding modes. The MDNode is an implementation detail and an awkward one for the front end to have to deal with.
I posted a patch showing the rounding and exception information being passed as enumeration not MDNode. I've uploaded the patch here, https://reviews.llvm.org/D62730



More information about the llvm-commits mailing list