[PATCH] D62734: [AArch64] Check for simple type in FPToUInt

[Sam Parker via Phabricator via llvm-commits]

samparker created this revision.
samparker added reviewers: silviu.baranga, t.p.northover.
Herald added subscribers: kristof.beyls, javed.absar.

DAGCombiner was hitting a SimpleType assertion when trying to combine a v3f32 before type legalization.

      

bugzilla: https://bugs.llvm.org/show_bug.cgi?id=41916


https://reviews.llvm.org/D62734

Files:
  lib/Target/AArch64/AArch64ISelLowering.cpp
  test/CodeGen/AArch64/v3f-to-int.ll


Index: test/CodeGen/AArch64/v3f-to-int.ll
===================================================================
--- /dev/null
+++ test/CodeGen/AArch64/v3f-to-int.ll
@@ -0,0 +1,17 @@
+; RUN: llc -mtriple=aarch64--linux-eabi %s -o - | FileCheck %s
+
+; CHECK-LABEL: convert_v3f32
+; CHECK: strb
+; CHECK: strh
+define void @convert_v3f32() {
+entry:
+  br label %bb
+
+bb:
+  %0 = shufflevector <4 x float> zeroinitializer, <4 x float> undef, <3 x i32> <i32 0, i32 1, i32 2>
+  %1 = fmul reassoc nnan ninf nsz contract afn <3 x float> %0, <float 2.550000e+02, float 2.550000e+02, float 2.550000e+02>
+  %2 = fptoui <3 x float> %1 to <3 x i8>
+  %3 = bitcast i8* undef to <3 x i8>*
+  store <3 x i8> %2, <3 x i8>* %3, align 1
+  ret void
+}
Index: lib/Target/AArch64/AArch64ISelLowering.cpp
===================================================================
--- lib/Target/AArch64/AArch64ISelLowering.cpp
+++ lib/Target/AArch64/AArch64ISelLowering.cpp
@@ -9206,6 +9206,9 @@
   if (!Subtarget->hasNEON())
     return SDValue();
 
+  if (!N->getValueType(0).isSimple())
+    return SDValue();
+
   SDValue Op = N->getOperand(0);
   if (!Op.getValueType().isVector() || !Op.getValueType().isSimple() ||
       Op.getOpcode() != ISD::FMUL)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62734.202430.patch
Type: text/x-patch
Size: 1232 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190531/7c89b003/attachment.bin>