[PATCH] D62728: [llvm-readobj] - Remove excessive `dynamic.test`

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 03:50:47 PDT 2019

grimar created this revision.
grimar added reviewers: jhenderson, rupprecht, MaskRay, jakehehrlich.
Herald added subscribers: kristof.beyls, javed.absar.
grimar edited the summary of this revision.

`dynamic.test` is a test that checks dumping of
dynamic tags. It uses precompiled objects as inputs
and it is completely excessive nowadays:

Now we have `elf-dynamic-tags-machine-specific.test`
and `elf-dynamic-tags.test`. 

First is used to check target
specific tags and second tests the common flags.
These tests use YAML, which is much better than using precompiled binaries.

Note that new reviews tend to update the YAML based
tests to add new tags, e.g. see D62596 <https://reviews.llvm.org/D62596>.

So I think we should remove `dynamic.test`.

With this patch became possible to remove
`dynamic-table-so.aarch64` binary from the inputs folder.
(other binaries are still used in other tests).



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62728.202411.patch
Type: text/x-patch
Size: 14612 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190531/a076e3d6/attachment.bin>

More information about the llvm-commits mailing list