[PATCH] D62707: [AMDGPU] Use InliningThresholdMultiplier for inline hint

Thu May 30 15:48:32 PDT 2019

arsenm added a comment.

In D62707#1524236 <https://reviews.llvm.org/D62707#1524236>, @rampitec wrote:

> In D62707#1524219 <https://reviews.llvm.org/D62707#1524219>, @arsenm wrote:
>
> > Needs test. I'm also not sure I follow how getInliningThresholdMultiplier is used. It looks like it's applied after any of the thresholds are computed in CallAnalyzer::updateThreshold?
> >
> > Also why do we actually override getInlineThreshold? The alloca object check seems like it shouldn't really be fundamentally different than the SROA checks the default InlineCost does
>
>
> I can add test, but it essentially will be a quite large function.

You can use the flags to make it a small function

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62707/new/

https://reviews.llvm.org/D62707