[PATCH] D62614: Fix for the OCL/LC to failure on some OCLPerf tests

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 00:28:55 PDT 2019

nhaehnle requested changes to this revision.
nhaehnle added a comment.
This revision now requires changes to proceed.

Changing the meaning of "uniform" in this way is just bound to lead to confusion further down the line, so please can we not do that?

I agree with Stas that the notion of "uniform" alone is simply not enough, though I'd phrase it this way: we need to distinguish between //uniform at definition// and //uniform at use//. The value inside the loop is uniform at definition, but it is not uniform when used outside the loop with divergent exit.



More information about the llvm-commits mailing list