[PATCH] D62589: [MIPS GlobalISel] Handle position independent code

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 00:01:07 PDT 2019


atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: lib/Target/Mips/MipsCallLowering.cpp:527
+  const bool IsCalleeGlobalPIC =
+      Callee.isGlobal() && MF.getTarget().isPositionIndependent();
+
----------------
You could write it as `Callee.isGlobal() && TM.isPositionIndependent();`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62589/new/

https://reviews.llvm.org/D62589





More information about the llvm-commits mailing list