[PATCH] D61843: [DAGCombine] Match a pattern where a wide type scalar value is stored by several narrow stores

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 20:46:17 PDT 2019


steven.zhang added a comment.

I will hold this patch until the test case update for systemZ is accepted.  D62370 <https://reviews.llvm.org/D62370>: [NFC] Check the endianness after the CodeGenPrepare.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6318
+
+  DAG.ReplaceAllUsesWith(N, NewStore.getNode());
+  return NewStore;
----------------
apilipenko wrote:
> steven.zhang wrote:
> > apilipenko wrote:
> > > What happens to the individual stores after? Do you rely on other DAG combine rules to remove them?
> > Exactly.
> Can you add a comment saying that?
ok


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61843/new/

https://reviews.llvm.org/D61843





More information about the llvm-commits mailing list