[PATCH] D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer

Seiya Nuta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 18:36:16 PDT 2019


seiya marked an inline comment as done.
seiya added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/Inputs/various-symbols.s:4
+# char global2 = 123; // A extern symbol.
+# int global3 = 456;  // A extern symbol.
+# extern int extern1, extern2, extern3, extern4; // Undefined symbols.
----------------
compnerd wrote:
> `global3` is unreferenced.  Is that intended?
That was a mistake. I've updated this file so it no longer matters btw.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62652/new/

https://reviews.llvm.org/D62652





More information about the llvm-commits mailing list