[PATCH] D62713: [MIR-Canon] Hardening propagateLocalCopies.

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: llvm/lib/CodeGen/MIRCanonicalizerPass.cpp:345
       continue;
+    // Not folding COPY instructions if regbankselect has not set the RCs.
+    if (nullptr == MRI.getRegClassOrNull(Dst))
----------------
Can you explain why the type along isn't sufficient


================
Comment at: llvm/lib/CodeGen/MIRCanonicalizerPass.cpp:346
+    // Not folding COPY instructions if regbankselect has not set the RCs.
+    if (nullptr == MRI.getRegClassOrNull(Dst))
+      continue;
----------------
I think that `if (!MRI.getRegClassOrNull(Dst))` is more LLVM style


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62713/new/

https://reviews.llvm.org/D62713