[PATCH] D62424: Tests for nosync function attribute.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 17:32:56 PDT 2019

jdoerfert added a comment.

In D62424#1520564 <https://reviews.llvm.org/D62424#1520564>, @sstefan1 wrote:

> In D62424#1520101 <https://reviews.llvm.org/D62424#1520101>, @jdoerfert wrote:
> > What was the problem there? How does the output actually look?
>   nosync.ll:130:15: error: CHECK-NEXT: is not on the line after the previous match
>   ; CHECK-NEXT: define void @call_nosync_function()
>             ^
>   <stdin>:55:1: note: 'next' match was here
>   define void @call_nosync_function() #2 {
>   ^
>   <stdin>:51:44: note: previous match ended here
>   ; Function Attrs: noinline nounwind uwtable
>                                          ^
>   <stdin>:52:1: note: non-matching line after previous match is here
>   declare void @nosync_function() #2
>   ^

Good thing we looked into this. You should look at the IR output (without lit) to see what the problem is but I would assume the decleration of `nosync_function` is placed before `call_nosync_function`. Then, the CHECK line you added for the attributes of the latter actually matches the attributes of the former. That would mean, adding another check line for the former, including the check-not nosync, will fix the issue and check-next will do what we want.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list