[PATCH] D62695: [AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is fp

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:2826
+  const TargetRegisterInfo &TRI = *MRI.getTargetRegisterInfo();
+
+  // First, check if the condition is defined by a compare.
----------------
This could do with a bit of documentation showing what we're trying to match and generate.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:2863
+  // Make sure we'll be able to select the compare.
+  // Delete the def itself; we'll generate our own compare here.
+  unsigned CmpOpc = selectFCMPOpc(*CondDef, MRI);
----------------
Can remove this delete comment because we're not explicitly deleting anything here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62695/new/

https://reviews.llvm.org/D62695