[PATCH] D62704: [WebAssembly] Improve feature validation error messages

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/wasm/Writer.cpp:379
       case WASM_FEATURE_PREFIX_DISALLOWED:
-        Disallowed.insert(Feature.Name);
+        Disallowed.insert({Feature.Name, FileName});
         break;
----------------
So in the case the multiple files use a given feature it will show just one them?  (i.e. this insert fails after the first one?)


================
Comment at: lld/wasm/Writer.cpp:419
   for (ObjFile *File : Symtab->ObjectFiles) {
+    std::string FileName(File->getName());
     SmallSet<std::string, 8> ObjectFeatures;
----------------
Why not StringRef?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62704/new/

https://reviews.llvm.org/D62704