[PATCH] D62555: [TailDuplicator] prevent tail duplication for INLINEASM_BR

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 13:19:42 PDT 2019

nickdesaulniers added a comment.

> so probably a bug in if conversion. Maybe the same issue as https://bugs.llvm.org/show_bug.cgi?id=41121 .

Interesting, and does look related.  While I try to make If Converter more robust in the face of INLINEASM_BR, I still think curtailing Tail Duplicator from duplicating INLINEASM_BR (and INLINEASM) is probably also worthwhile, and kind of makes robustness changes to If Converter less important.  I'm going to spend the rest of the day trying to improve If Converter, but ultimately this is holding up asm goto from working perfectly (which is more important to me), so if I don't have anything working by EOD, then tomorrow I will make the suggested edits here and focus on this patch.

> So I have a patch in hand that basically does this.

In particular, I'm not super happy with it, which is why I haven't posted it yet.  I think there's yet another/better way to solve the problem in If Converter, but requires more work.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list