[PATCH] D62694: Write new tests for r362121

[Michael Trent via Phabricator via llvm-commits]

mtrent created this revision.
mtrent added reviewers: pete, lhames.
Herald added subscribers: rupprecht, aprantl.
Herald added a reviewer: JDevlieghere.
Herald added a project: LLVM.

The tests for r362121 ran dsymutil against a test binary every time.
This caused problems on lld-x86_64-ubuntu-fast as dsymutil required
a lipo tool be available to process those binaries.

This change rewrites the new test cases in macho-disassemble-g-dsym
to use bespoke test binaries (exe and dwarf) simplifying the test's
runtime dependencies.

The changes to tools/llvm-objdump/MachODump.cpp are unchanged from
r362121


Repository:
  rL LLVM

https://reviews.llvm.org/D62694

Files:
  test/tools/llvm-objdump/X86/Inputs/hello-macho-fat
  test/tools/llvm-objdump/X86/Inputs/hello-macho-fat.dwarf
  test/tools/llvm-objdump/X86/Inputs/hello-macho-thin
  test/tools/llvm-objdump/X86/Inputs/hello-macho-thin.dwarf
  test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test
  tools/llvm-objdump/MachODump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62694.202264.patch
Type: text/x-patch
Size: 4365 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190530/aa91e81f/attachment.bin>