[PATCH] D62576: Remove the redundant using LoopVectorizationPlanner:VPlanPtr

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 11:43:22 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL362126: [LV] Remove the redundant using LoopVectorizationPlanner:VPlanPtr (authored by fhahn, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D62576?vs=201849&id=202261#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62576/new/

https://reviews.llvm.org/D62576

Files:
  llvm/trunk/lib/Transforms/Vectorize/LoopVectorizationPlanner.h
  llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp


Index: llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp
===================================================================
--- llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp
+++ llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp
@@ -56,6 +56,7 @@
 #include "llvm/Transforms/Vectorize/LoopVectorize.h"
 #include "LoopVectorizationPlanner.h"
 #include "VPRecipeBuilder.h"
+#include "VPlan.h"
 #include "VPlanHCFGBuilder.h"
 #include "VPlanHCFGTransforms.h"
 #include "VPlanPredicator.h"
@@ -6829,8 +6830,7 @@
   }
 }
 
-LoopVectorizationPlanner::VPlanPtr
-LoopVectorizationPlanner::buildVPlanWithVPRecipes(
+VPlanPtr LoopVectorizationPlanner::buildVPlanWithVPRecipes(
     VFRange &Range, SmallPtrSetImpl<Value *> &NeedDef,
     SmallPtrSetImpl<Instruction *> &DeadInstructions) {
   // Hold a mapping from predicated instructions to their recipes, in order to
@@ -6954,8 +6954,7 @@
   return Plan;
 }
 
-LoopVectorizationPlanner::VPlanPtr
-LoopVectorizationPlanner::buildVPlan(VFRange &Range) {
+VPlanPtr LoopVectorizationPlanner::buildVPlan(VFRange &Range) {
   // Outer loop handling: They may require CFG and instruction level
   // transformations before even evaluating whether vectorization is profitable.
   // Since we cannot modify the incoming IR, we need to build VPlan upfront in
Index: llvm/trunk/lib/Transforms/Vectorize/LoopVectorizationPlanner.h
===================================================================
--- llvm/trunk/lib/Transforms/Vectorize/LoopVectorizationPlanner.h
+++ llvm/trunk/lib/Transforms/Vectorize/LoopVectorizationPlanner.h
@@ -198,11 +198,9 @@
   /// The legality analysis.
   LoopVectorizationLegality *Legal;
 
-  /// The profitablity analysis.
+  /// The profitability analysis.
   LoopVectorizationCostModel &CM;
 
-  using VPlanPtr = std::unique_ptr<VPlan>;
-
   SmallVector<VPlanPtr, 4> VPlans;
 
   /// This class is used to enable the VPlan to invoke a method of ILV. This is


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62576.202261.patch
Type: text/x-patch
Size: 1940 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190530/1dee1179/attachment.bin>


More information about the llvm-commits mailing list