[PATCH] D62430: [PPC] Correctly adjust branch probability in PPCReduceCRLogicals

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 11:41:50 PDT 2019


Carrot marked an inline comment as done.
Carrot added inline comments.


================
Comment at: lib/Target/PowerPC/PPCReduceCRLogicals.cpp:187
+      ProbFallThrough = ProbToNewTarget.getCompl();
+      ProbOrigFallThrough = ProbToNewTarget / ProbToNewTarget.getCompl();
+      ProbOrigTarget = ProbOrigFallThrough.getCompl();
----------------
xur wrote:
> NIT: Probably use ProbFallThough?
I use the current expression to make it consistent with the formula in line 178.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62430/new/

https://reviews.llvm.org/D62430





More information about the llvm-commits mailing list