[PATCH] D62656: Make SwitchInstProfUpdateWrapper safer

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 11:08:13 PDT 2019


yrouban marked an inline comment as done.
yrouban added inline comments.


================
Comment at: llvm/lib/IR/Instructions.cpp:3907
+
+  if (ProfileData->getNumOperands() != SI.getNumSuccessors() + 1) {
+    State = Invalid;
----------------
davidxl wrote:
> should we fix the underlying problem that leads to this inconsistent state?
That is what I'm trying to do.
The problem could have been solved by one of the proposed patches. See the dependency graph.
It would be great to identify where the problem stems from.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62656/new/

https://reviews.llvm.org/D62656





More information about the llvm-commits mailing list