[PATCH] D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 06:09:09 PDT 2019


yrouban requested review of this revision.
yrouban added a comment.
This revision is now accepted and ready to land.

In D62126#1520054 <https://reviews.llvm.org/D62126#1520054>, @nikic wrote:

> Providing an obviously incorrect branch_weights for one of the added test cases is enough to cause an assertion failure:


I have just submitted a fix. Please see D62656 <https://reviews.llvm.org/D62656>. Once it is landed this patch can be landed unchanged.
I decided to not include the crash test case as it would be caught by verification proposed in D61179 <https://reviews.llvm.org/D61179>.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62126/new/

https://reviews.llvm.org/D62126





More information about the llvm-commits mailing list