[PATCH] D60694: [ARM] Introduce separate features for FP registers.

Oliver Stannard (Linaro) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 02:51:48 PDT 2019

ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.

LGTM with one nit.

Comment at: test/MC/ARM/mve-vmov-lane.s:3
+// v8.1M added the Q register syntax for this instruction. The v8.1M spec does
+// not list the D register syntax as valid, but we accept it as an extension to
This comment isn't true yet, we should probably move this whole file to the patch which adds the v8.1M syntax change.

Comment at: test/MC/Disassembler/ARM/mve-vmov-lane.txt:4
+# The disassembly for this instruction varies between v8.1M and other
+# architectures. In v8.1M (with either scalar floating point, MVE or both), we
Again, this isn't true yet, I think it'd be better to move the whole file to a later patch.



More information about the llvm-commits mailing list