[PATCH] D62595: [AARCH64][ELF][llvm-readobj] Support for AArch64 .note.gnu.property

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3748
     return OS.str();
+  case GNU_PROPERTY_AARCH64_FEATURE_1_AND:
+    OS << "aarch64 feature: ";
----------------
Seems you should be able to share the logic with `GNU_PROPERTY_X86_FEATURE_1_AND`?

i.e. 

```

case GNU_PROPERTY_X86_FEATURE_1_AND:
case GNU_PROPERTY_AARCH64_FEATURE_1_AND:
....

OS << (Type == GNU_PROPERTY_AARCH64_FEATURE_1_AND) ?
  "aarch64 feature: " : "x86 feature: ";
...
```

and so on. Will it be better?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62595/new/

https://reviews.llvm.org/D62595