[PATCH] D62596: [AARCH64][ELF][llvm-readobj] Add support for BTI and PAC dynamic tags

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 02:33:01 PDT 2019

peter.smith marked 3 inline comments as done.
peter.smith added a comment.

Thanks for the comments, I hope to have an update later today.

Comment at: test/tools/llvm-readobj/aarch64-bti-pac-dynamic.test:1
+# Check DT_MIPS_OPTIONS .dynamic section tag reading
peter.smith wrote:
> grimar wrote:
> > ostannard wrote:
> > > Copy-pasted comment?
> > It is becoming common to start comments from `##` in LLVM tools.
> > (see dynamic-section-arch-tags.test below, for example).
> Yes will fix, thanks for the spot.
Thanks, will do.

Comment at: test/tools/llvm-readobj/aarch64-bti-pac-dynamic.test:3
+RUN: llvm-readobj --dynamic-table %p/Inputs/bti-pac-plt.elf-aarch64 | \
+RUN:   FileCheck %s
grimar wrote:
> Lets use yaml2obj instead of precompiled binary.
Ok, will do so.

Comment at: test/tools/llvm-readobj/aarch64-bti-pac-dynamic.test:23
+CHECK-NEXT:   0x0000000000000000 NULL                 0x0
grimar wrote:
> You can probably omit dumping of other tags.
Ok will do.



More information about the llvm-commits mailing list