[PATCH] D62596: [AARCH64][ELF][llvm-readobj] Add support for BTI and PAC dynamic tags

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/llvm-readobj/aarch64-bti-pac-dynamic.test:1
+# Check DT_MIPS_OPTIONS .dynamic section tag reading
+
----------------
ostannard wrote:
> Copy-pasted comment?
It is becoming common to start comments from `##` in LLVM tools.
(see dynamic-section-arch-tags.test below, for example).


================
Comment at: test/tools/llvm-readobj/aarch64-bti-pac-dynamic.test:3
+
+RUN: llvm-readobj --dynamic-table %p/Inputs/bti-pac-plt.elf-aarch64 | \
+RUN:   FileCheck %s
----------------
Lets use yaml2obj instead of precompiled binary.


================
Comment at: test/tools/llvm-readobj/aarch64-bti-pac-dynamic.test:15
+CHECK-NEXT:   0x0000000070000001 AARCH64_BTI_PLT      0
+CHECK-NEXT:   0x0000000070000003 AARCH64_PAC_PLT      0x0
+CHECK-NEXT:   0x0000000000000006 SYMTAB               0x200258
----------------
ostannard wrote:
> Why is the value for PAC printed as "0x0", but BTI is just "0"?
FWIW it is not an issue of this patch it seems.


================
Comment at: test/tools/llvm-readobj/aarch64-bti-pac-dynamic.test:23
+CHECK-NEXT:   0x0000000000000000 NULL                 0x0
+CHECK-NEXT: ]
----------------
You can probably omit dumping of other tags.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:1466
   switch (Arch) {
+
+  case EM_AARCH64:
----------------
Excessive empty line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62596/new/

https://reviews.llvm.org/D62596