[PATCH] D61185: [RISCV] Add CostModel GEP tests

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 02:19:06 PDT 2019


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

LGTM with minor nit



================
Comment at: test/Analysis/CostModel/RISCV/gep.ll:18
+; RVI-NEXT:  Cost Model: Found an estimated cost of 0 for instruction: ret void
+;
+  %a0 = getelementptr inbounds i8, i8* %a, i32 0
----------------
Nit: I think these empty comment lines are unwanted and an artifact of when there were two different check prefixes


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61185/new/

https://reviews.llvm.org/D61185





More information about the llvm-commits mailing list