[PATCH] D62577: [ELF] Support Local Dynamic style TLSDESC for x86-64
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 30 01:51:03 PDT 2019
grimar added inline comments.
Comment at: ELF/Writer.cpp:1626
+ Symtab->TlsModuleBase = S;
Should this assignment be under `if (S && S->isUndefined())` check?
I am not sure how much is real (I guess not at all honestly). but if user defines his own `_TLS_MODULE_BASE_` symbol, then
with the current code `getTlsTpOffset` would return 0 for it. It is probably not user would expect.
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
More information about the llvm-commits