[PATCH] D62605: [X86] Avoid SFB - Ignore meta instructions

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 16:16:34 PDT 2019


aprantl added inline comments.


================
Comment at: llvm/test/CodeGen/X86/avoid-sfb-ignore-meta.mir:46
+
+  attributes #0 = { norecurse nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+  attributes #1 = { nounwind readnone speculatable }
----------------
Please remove the string-attributes, they are probably not necessary and hard to maintain.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62605/new/

https://reviews.llvm.org/D62605





More information about the llvm-commits mailing list