[PATCH] D62510: [LoopVectorize] Add FNeg instruction support

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 15:14:19 PDT 2019

fhahn added a comment.

In D62510#1522129 <https://reviews.llvm.org/D62510#1522129>, @craig.topper wrote:

> @fhahn does the test look ok to pre-commit now?

Personally I think the auto-generated assertions here do not really add much value, as they contain plenty of unrelated stuff and make the test more fragile than necessary. IMO it would be better to focus the check on the relevant bits: ensure we generate load -> fneg -> store in the vector body. But if you think the complete checks are more valuable, please commit the test as is, I do not have too strong feelings about it.

For some reason I missed the changes to `LoopVectorizationCostModel::getInstructionCost`. For those, a target-specific test would be good. I think most LV tests for that check the cost printed in the debug messages.



More information about the llvm-commits mailing list