[PATCH] D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on

Michael Spencer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 15:06:50 PDT 2019


Bigcheese added a reviewer: chandlerc.
Bigcheese added a comment.

In D62627#1522081 <https://reviews.llvm.org/D62627#1522081>, @zhizhouy wrote:

> IIUC, user will always call clang to pass integrated as flag. Actually I also used to consider checking UseIntegratedAS-ish in PassBuilder,
>  but looking for a codegen options in PassBuilder seems going to break the integrity. Solutions for this is appreciated.


There are frontends and users of llvm other than clang.

Also all of the other options there are useful for experimenting with new passes, none of them are required for correctness, and none of them are ever set by clang.

Adding Chandler to see if he has a good solution.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62627/new/

https://reviews.llvm.org/D62627





More information about the llvm-commits mailing list