[PATCH] D62369: [ADT] Enable set_difference() to be used on StringSet
Mike Pozulp via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 29 14:41:02 PDT 2019
mmpozulp updated this revision to Diff 202059.
mmpozulp added a comment.
Incorporate feedback from @dblaikie to call insert(StringMapEntry) and count(StringMapEntry) instead of set_difference(StringSet, StringSet) in StringSetTest.cpp, which better adheres to the spirit of unit-testing.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62369/new/
https://reviews.llvm.org/D62369
Files:
llvm/include/llvm/ADT/StringMap.h
llvm/include/llvm/ADT/StringSet.h
llvm/unittests/ADT/CMakeLists.txt
llvm/unittests/ADT/StringMapTest.cpp
llvm/unittests/ADT/StringSetTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62369.202059.patch
Type: text/x-patch
Size: 3865 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190529/92085e6a/attachment.bin>
More information about the llvm-commits
mailing list