[PATCH] D62546: [FPEnv] Added a special UnrollVectorOp method to deal with the chain on StrictFP opcodes

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1341
+  unsigned i;
+  for (i= 0; i != NE; ++i) {
+    Operands[0] = Chain;
----------------
Missing a space in `i = 0`.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1343
+    Operands[0] = Chain;
+    for (unsigned j = 1, e = N->getNumOperands(); j != e; ++j) {
+      SDValue Operand = N->getOperand(j);
----------------
What's the purpose of `e` here? Why not:

`for (unsigned j = 1, j != N->getNumOperands(); ++j) {`

Is it just saving an accessor call?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62546/new/

https://reviews.llvm.org/D62546