[PATCH] D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on

Zhizhou Yang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 14:33:57 PDT 2019


zhizhouy added a comment.

IIUC, user will always call clang to pass integrated as flag. Actually I also used to consider checking UseIntegratedAS-ish in PassBuilder,
but looking for a codegen options in PassBuilder seems going to break the integrity. Solutions for this is appreciated.

In D62627#1522048 <https://reviews.llvm.org/D62627#1522048>, @Bigcheese wrote:

> I also have an issue with the name as `CGProfilePass` doesn't actually do the sorting


Sorry I mis-used the "sort" here, changing it to "enable-npm-call-graph-profile" to match the other newpm options in PassBuilder.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62627/new/

https://reviews.llvm.org/D62627





More information about the llvm-commits mailing list