[PATCH] D62560: Fix a crash when the default of a switch is removed
    Karl-Johan Karlsson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed May 29 14:00:25 PDT 2019
    
    
  
karka added a comment.
The fix LGTM (with the minor comment about the testcase).
================
Comment at: test/Transforms/LowerSwitch/condition-phi-unreachable-default.ll:1
+; RUN: opt < %s -lowerswitch -disable-output
+
----------------
I think that it make sense to always check that the output is sane with FileCheck even if the testcase only should demonstrate that the code don't crash.  Do you mind adding "-S | FileCheck %s"  (instead of -disable-output) to the command line and add a few checks?
Repository:
  rL LLVM
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62560/new/
https://reviews.llvm.org/D62560
    
    
More information about the llvm-commits
mailing list