[llvm] r362012 - IR: add optional type to 'byval' function parameters

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 13:34:36 PDT 2019


Hi David,

On 29 May 2019, at 13:31, David Blaikie <dblaikie at gmail.com> wrote:
> Sorry about this, but Google-internal build testing is tripping over this change when it comes to bootstrapping compiler-rt (with some "Attribute 'byval' type does not match parameter!"). Did you happen to test a bootstrap?

I’m investigating now. I believe the issue is that llvm-link (and hence LTO) doesn’t merge types within byval yet. I expect to have a fix in about an hour.

> Reckon it's worth reverting while I investigate on my side? (or if you think the chances are good it's only a Google internal issue, that's fair & I can just try to figure out what's off with our internal build system)

I’m happy to revert while I work on it if that’s too slow. Just send word or do it yourself, whichever is most convenient for you.

Cheers.

Tim.


More information about the llvm-commits mailing list