[PATCH] D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters

[Tim Northover via Phabricator via llvm-commits]

t.p.northover updated this revision to Diff 201991.
t.p.northover added a comment.
Herald added subscribers: aheejin, sbc100, nhaehnle, jvesely.

I think I've fixed everything suggested, including making the comparison assert if it ever happens since that seems to be the consensus.

I also noticed some Clang tests will need to be updated because byval now sorts slightly differently, so I've included those in the diff here for completeness.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62319/new/

https://reviews.llvm.org/D62319

Files:
  clang/test/CodeGen/aapcs-align.cpp
  clang/test/CodeGenCXX/builtin-source-location.cpp
  clang/test/CodeGenCXX/wasm-args-returns.cpp
  clang/test/CodeGenCXX/x86_64-arguments-nacl-x32.cpp
  clang/test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
  clang/test/CodeGenOpenCL/kernels-have-spir-cc-by-default.cl
  llvm/docs/LangRef.rst
  llvm/include/llvm/CodeGen/TargetLowering.h
  llvm/include/llvm/IR/Argument.h
  llvm/include/llvm/IR/Attributes.h
  llvm/include/llvm/IR/CallSite.h
  llvm/include/llvm/IR/Function.h
  llvm/include/llvm/IR/InstrTypes.h
  llvm/lib/AsmParser/LLParser.cpp
  llvm/lib/AsmParser/LLParser.h
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/Bitcode/Writer/ValueEnumerator.cpp
  llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
  llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
  llvm/lib/IR/AttributeImpl.h
  llvm/lib/IR/Attributes.cpp
  llvm/lib/IR/Function.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/test/Assembler/byval-type-attr.ll
  llvm/test/Assembler/invalid-byval-type1.ll
  llvm/test/Assembler/invalid-byval-type2.ll
  llvm/test/Assembler/invalid-byval-type3.ll
  llvm/test/Bitcode/Inputs/byval-upgrade.bc
  llvm/test/Bitcode/attributes-3.3.ll
  llvm/test/Bitcode/attributes.ll
  llvm/test/Bitcode/byval-upgrade.test
  llvm/test/Bitcode/compatibility-3.6.ll
  llvm/test/Bitcode/compatibility-3.7.ll
  llvm/test/Bitcode/compatibility-3.8.ll
  llvm/test/Bitcode/compatibility-3.9.ll
  llvm/test/Bitcode/compatibility-4.0.ll
  llvm/test/Bitcode/compatibility-5.0.ll
  llvm/test/Bitcode/compatibility-6.0.ll
  llvm/test/Bitcode/compatibility.ll
  llvm/test/Bitcode/highLevelStructure.3.2.ll
  llvm/test/CodeGen/AArch64/byval-type.ll
  llvm/test/Transforms/Inline/byval-tail-call.ll
  llvm/unittests/IR/AttributesTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62319.201991.patch
Type: text/x-patch
Size: 56690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190529/eb2350f6/attachment.bin>