[PATCH] D62521: [IRBuilder] Add CreateFNegFMF(...) to the IRBuilder

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 11:03:48 PDT 2019

craig.topper added a comment.

So my thought is that using UnaryOperator::CreateFNeg is only safe if we only use it when we started with an fneg. Or that the we are sure all passes downstream of whichever passes uses this can handle the presence of an fneg instruction in IR even if they don't know how to optimize it. Basically I'm concerned with sudden introduction of fnegs into IR before all passes are ready. But if we started with an fneg then it must have been testing IR and not clang produced IR.



More information about the llvm-commits mailing list