[PATCH] D62555: [TailDuplicator] prevent tail duplication for INLINEASM_BR

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 10:57:09 PDT 2019


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/TailDuplicator.cpp:784
     return false;
+  for (MachineInstr &I : *TailBB)
+    if (I.getOpcode() == TargetOpcode::INLINEASM_BR)
----------------
This will happen for each predecessor since the caller is in a loop right? Maybe we should check this before the loop in tailDuplicate? Are the othercallers of canTailDuplicate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62555/new/

https://reviews.llvm.org/D62555





More information about the llvm-commits mailing list