[PATCH] D62607: LoopDistribute/LAA: Respect convergent

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 10:03:26 PDT 2019

arsenm marked an inline comment as done.
arsenm added inline comments.

Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1783
+  // At first assume there are.
+  CanInsertRuntimeCheck = false;
jdoerfert wrote:
> I would have assumed this to be true initially and set to false if a convergent call was found. That would also remove one of the variables. If there is a reason agains it, please explain.
The loop scanning for this has early returns, so it may never reach the convergent instruction. Since at least LoopDistribution partially ignores the final result of the CanVecMem analysis, I thought it would be better to keep this as the conservative answer even if the loop bails out early.



More information about the llvm-commits mailing list