[PATCH] D61694: Boilerplate for producing XCOFF object files from the PowerPC backend.

[Sean Fertile via Phabricator via llvm-commits]

sfertile marked 2 inline comments as done.
sfertile added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:68
+  // Timestamp converted to an int32_t.
+  W.write<int32_t>(Now);
+  // Byte Offset to the start of the symbol table.
----------------
hfinkel wrote:
> Will the tools on AIX complain if this is 0? Our general policy is that the compiler's output should be deterministic/reproducible and this breaks that. Looks like D23934 was never finished, but this value should be tied to that (once it's finished).
> 
No a zero value should be fine. Is the goal the compiler always produces reproducible output by default, or just that we can enable reproducible output with an option?


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.h:59
+/// Construct a PPC XCOFF object writer.
+std::unique_ptr<MCObjectTargetWriter> createPPCXCOFFObjectWriter();
+
----------------
stefanp wrote:
> Here too maybe we want to keep the 64 bit flag?
Yeah, good idea. The first few patches for the Objectwriter are 32-bit only but we can simply report an error on 64-bit output for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61694/new/

https://reviews.llvm.org/D61694