[PATCH] D62577: [ELF] Support Local Dynamic style TLSDESC for x86-64
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 29 05:25:34 PDT 2019
ruiu added inline comments.
================
Comment at: ELF/InputSection.cpp:599
+ // On targets that support TLSDESC, _TLS_MODULE_BASE_ at tpoff = 0.
+ if (S.getName() == "_TLS_MODULE_BASE_")
+ return 0;
----------------
This line can be expensive if we have a lot of thread-local local symbols. getName() computes symbol names lazily, so if you call it on a local symbol, the function can be expensive. Maybe you should store TLSModuleBase symbol somewhere and compare S with the pointer?
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62577/new/
https://reviews.llvm.org/D62577
More information about the llvm-commits
mailing list