[PATCH] D62570: [WIP] Use LLVM's debug line parser in LLDB

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

Interesting stuff. I was wondering why you even needed to construct the `DWARFContext` and `DWARFUnit`, so I looked around a bit. It looks like they are only used for calling `DWARFFormValue::extract` to fetch the strings from the string table in the V5 case. So, it sounds like we need the `DWARFContext` to reach the string table, but maybe we don't need to create the `DWARFUnit` ? After all, one of the main goals of DWARF5 debug_lines was to have them be independent of the debug_info section.

What I'm trying to get at here is that it may be possible to limit the amount of work being done in `DWARFContext` by passing it only the small set of sections that it needs to get this parsed (something like debug_line, debug_str, debug_line_str ?).

BTW, I am also going to be touching this code slightly, as I'm trying to make sure the "support file" lists are shared between the various type units. However, it hopefully won't conflict with this too much, as I mostly approach it from the "other end" (i.e., what happens to the file lists after they have been parsed).


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62570/new/

https://reviews.llvm.org/D62570