[PATCH] D62520: [llvm-readobj/llvm-readelf] - Implement GNU style dumper of the SHT_GNU_verdef section.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM, but you may want to wait for others to comment.



================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3523
+  const Elf_Shdr *StrTabSec = unwrapOrError(Obj->getSection(Sec->sh_link));
+  StringRef StringTable = {
+      reinterpret_cast<const char *>(Obj->base() + StrTabSec->sh_offset),
----------------
`StringRef a(...)` or `String a{...}` are probably more common.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62520/new/

https://reviews.llvm.org/D62520