[PATCH] D62516: [llvm-readobj/llvm-readelf] - Implement GNU style dumper of the SHT_GNU_verneed section.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 28 22:33:08 PDT 2019
MaskRay added inline comments.
================
Comment at: test/tools/llvm-readobj/elf-verneed-flags.yaml:1
+## Check how llvm-readobj/llvm-readelf tools dump the flags of SHT_GNU_verneed
+## section entries.
----------------
delete `the flags of `?
================
Comment at: test/tools/llvm-readobj/elf-verneed-flags.yaml:104
+ Other: 0
+## Needed to trigger .dynstr creation.
+DynamicSymbols:
----------------
Probably elaborate a bit, `.dynstr` is required by `.gnu.version_r`
================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3436
StringRef SymTabName = unwrapOrError(Obj->getSectionName(SymTab));
OS << " Addr: " << format_hex_no_prefix(Sec->sh_addr, 16)
<< " Offset: " << format_hex(Sec->sh_offset, 8)
----------------
Nit: `" Addr: "` (two spaces before `"Addr:"`)
GNU readelf prints `0x` prefix for `.gnu.version_d` and `.gnu.version_r` but omits the prefix for `.gnu.version`... I think the inconsistency may be due to a bug. We may stick with one style :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62516/new/
https://reviews.llvm.org/D62516
More information about the llvm-commits
mailing list