[PATCH] D59334: [TSan][libdispatch] Enable linking and running of tests on Linux

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 16:35:09 PDT 2019


beanz added inline comments.


================
Comment at: compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake:598
                -DCMAKE_BUILD_TYPE=Release
+               -DCMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY
                -DLLVM_PATH=${LLVM_MAIN_SRC_DIR}
----------------
FYI, this isn't safe to do. `CMAKE_TRY_COMPILE_TARGET_TYPE` was added in CMake 3.6, and LLVM and Compiler-RT support building with CMake 3.4 and up.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59334/new/

https://reviews.llvm.org/D59334





More information about the llvm-commits mailing list