[PATCH] D62540: [SampleFDO] For functions without profiles, provide an option to put them in a special text section

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 16:11:55 PDT 2019


wmi added a comment.

In D62540#1520129 <https://reviews.llvm.org/D62540#1520129>, @davidxl wrote:

> Why is symbol remapping an issue? old MD5 --> input symbol name -> output symbol name --> mapped MD5sum ?


We want to use profile remapping support when we want to find the counterparts in profile for the set of symbols being renamed during optimized build after a large scale codebase refactoring. The profile remapping support doesn't work well if the symbols in the profile are md5. If the symbol whitelist contain md5, after refactoring, profile remapping will not find old symbols being renamed in the whitelist and will think they are all new symbols.

Existing profile remapping doesn't support comparing old MD5 with the mapped MD5. profile remapping is based on C++ mangling, so only symbol names are supported during remapping.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62540/new/

https://reviews.llvm.org/D62540





More information about the llvm-commits mailing list